multigas calibration details#2747
Conversation
ozym
left a comment
ozym
left a comment
There was a problem hiding this comment.
There seems to be two different sets of labels, e.g. the file:
Station,Location,Gas,Concentration,Frequency,DayofWeek,CalTime,ZerTime,Start Date,End Date
vs those in the README.
I suggest some gathering together, e.g.
Station
Location
Gas
Concentration
Frequency
Day Of Week
Calibration Time
Zero Time
Start Date
End Date
- not 100% sure about "Zero Time" as a label but not too worried..
Also, have a think about adjusting the way of writing times, e.g.
02:10:00 could be 2h10m etc.
This may make it easier to read?
|
Thanks @ozym. The different labels was just my slopping work - changed one but didn't check the other, they now match. |
ozym
left a comment
ozym
left a comment
There was a problem hiding this comment.
Only comment is where did the number of the week come from, i.e. 0 == monday etc.
Normally in NZ it's 1 == Monday through to 7 == Sunday (as per the first day of the year being 001).
Although, this is encoded in go via:
const (
Sunday = iota
Monday
Tuesday
Wednesday
Thursday
Friday
Saturday
)which is 0 to 6 with 0 being Sunday (which is also different, but Monday is still 1).
Not fussed really but it is something that needs to be carefully noted for users (and when decoding the expected calibration days).
|
Actually, thinking about this. Would it be possible to simply use real words. e.g. Day of Week is one of: And frequency is: "Daily", "Weekly", etc We don't need to make it so cryptic it needs decoding. |
|
I had actual day names, and then changed it to numbers as it was cleaner to code with 😆 but I agree names is better for a general audience. I will revert to that. |
|
One other thing, as this is meant to be used for actual automatic processing (rather than a reference), I think it would be better to put the csv files in the top of the calibration tree (and update the README there). e.g.
I can then do automatic checks/tests etc. |
|
I have made those changes @ozym. I have left a reference to the multigas folder in the README as we'll use that for detection limit information when that is fully sorted, though no folder or file there yet. |
ozym
left a comment
ozym
left a comment
There was a problem hiding this comment.
I'll do a follow up PR with wrap around code.
|
Thanks Mark. Ping me to review that when you are ready. |
2 participants
Initial entry of multigas calibration details, plus README files